gh-130474: Create and implement flaky resource#130489
Closed
floor-licker wants to merge 17 commits intopython:mainfrom
Closed
gh-130474: Create and implement flaky resource#130489floor-licker wants to merge 17 commits intopython:mainfrom
floor-licker wants to merge 17 commits intopython:mainfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created the resource and implemented it in some obvious places where comments pointed to flaky tests. There were certain tests I left alone as although they were marked flaky by inline comments, there were other decorators addressing this, for example certain tests that were marked as being flaky without the GIL are already marked with the
@support.requires_gil_enableddecorator which I think makes more sense.As with other resources, the use-case for decorating tests is just:
With this set-up, in CI environments we can configure the CI to run flaky tests separately and to automatically retry failed flaky tests::
python -m test --use=flaky --rerun